struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Graham" <>
Subject Re: Avoid code reformating !
Date Mon, 16 Dec 2002 23:44:07 GMT
A couple of things:
1.  Tabs were addressed as an issue but the jakarta guidelines state that 
tabs are not to be used in the first place.  This drives me crazy but I 
follow it nonetheless.
2.  I agree with closing one line blocks but this isn't in any standard.  
I've seen a lot of Struts code that will follow an unclosed one line block 
with more code which makes it very confusing.  This is fair game for 
changing in my book.
3.  I disagree that we should stop formatting code.  We have a standard that 
we should be following.  If we need to change that standard then we can 
debate that.


>From: Erik Hatcher <>
>Reply-To: "Struts Developers List" <>
>To: Struts Developers List <>
>Subject: Re: Avoid code reformating !
>Date: Mon, 16 Dec 2002 18:25:55 -0500
>As for seeing a class structure, this is what IDE's like Eclipse and IDEA 
>make a moot point.  I think if code doesn't follow the Jakarta (or 
>project-specific) conventions then its fair game for reformatting.  This is 
>communal code and no one person owns it, this is why conventions exist and 
>we must adhere to them for the sake of the "community".  Please.
>But, while we are talking about coding conventions, at least please adopt 
>closing if/for/while/etc blocks with curly brackets for one-line blocks.  
>The Struts codebase is littered with non-curly-bracketed one-line blocks 
>and that in and of itself drives me nuts when I'm trying to follow the 
>code.  :))
>	Erik
>Cedric Dumoulin wrote:
>>  I said that I don't want to debate on this. I know the reformated code 
>>doesn't follow the recomanded Jakarta rules code standard. But another 
>>rule is to respect any other well formated standard ;-).
>>  For me, the reformated code is really unreadable: I can't detect the 
>>classes and methods structures at a glance, and so it requires me some 
>>times to try to figure it out. I thing it is a waste of time ...
>>     Cedric
>To unsubscribe, e-mail:   
>For additional commands, e-mail: 

Protect your PC - get VirusScan Online

To unsubscribe, e-mail:   <>
For additional commands, e-mail: <>

View raw message