struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Cooper" <martin.coo...@tumbleweed.com>
Subject RE: cvs commit: jakarta-struts/src/share/org/apache/struts/action Action.java
Date Mon, 01 Jul 2002 16:34:41 GMT
Well, I have to admit to an ulterior motive in fixing that particular one -
I was exploring the viability of using Eclipse 2.0 for developing Struts,
and wanted to try out the CVS integration. ;-) (Verdict: It works for almost
all of it, but it's a real bear to set up.)

In general, yes, I'd like to see us fixing all such references. However,
it's not a high priority for Beta 2. The best thing to do is, if you see
cases of this, or the parameter naming issue you mentioned (which seems like
it should be higher priority), submit Bugzilla reports and we'll fix what we
can. We can always mark them LATER if we don't get to them right away, but
at least the issues will be logged.

--
Martin Cooper

> -----Original Message-----
> From: James Mitchell [mailto:jmitchtx@telocity.com]
> Sent: Monday, July 01, 2002 6:23 AM
> To: Struts Developers List
> Subject: RE: cvs commit:
> jakarta-struts/src/share/org/apache/struts/action Action.java
> 
> 
> Are you changing all references from
> struts:whatever to html:whatever?
> 
> Also, do you care about fixing the javadoc comments to reflect correct
> parameter names or is it a non-issue for now?  (I know you're 
> trying to get
> 1.1 ready)
> 
> James Mitchell
> Software Engineer\Struts Evangelist
> Struts-Atlanta, the "Open Minded Developer Network"
> http://www.open-tools.org/struts-atlanta
> 
> 
> 
> 
> > -----Original Message-----
> > From: martinc@apache.org [mailto:martinc@apache.org]
> > Sent: Monday, July 01, 2002 12:11 AM
> > To: jakarta-struts-cvs@apache.org
> > Subject: cvs commit: 
> jakarta-struts/src/share/org/apache/struts/action
> > Action.java
> >
> >
> > martinc     2002/06/30 21:10:38
> >
> >   Modified:    src/share/org/apache/struts/action Action.java
> >   Log:
> >   Fixed in 20020701 nightly build.
> >
> >   Revision  Changes    Path
> >   1.42      +6 -6
> > jakarta-struts/src/share/org/apache/struts/action/Action.java
> >
> >   Index: Action.java
> >   
> ===================================================================
> >   RCS file:
> > 
> /home/cvs/jakarta-struts/src/share/org/apache/struts/action/Ac
> tion.java,v
> >   retrieving revision 1.41
> >   retrieving revision 1.42
> >   diff -u -r1.41 -r1.42
> >   --- Action.java	25 Jun 2002 00:42:44 -0000	1.41
> >   +++ Action.java	1 Jul 2002 04:10:38 -0000	1.42
> >   @@ -645,7 +645,7 @@
> >
> >        /**
> >         * Save the specified error messages keys into the
> > appropriate request
> >   -     * attribute for use by the &lt;struts:errors&gt; tag, if
> > any messages
> >   +     * attribute for use by the &lt;html:errors&gt; tag, if
> > any messages
> >         * are required.  Otherwise, ensure that the request
> > attribute is not
> >         * created.
> >         *
> >   @@ -669,7 +669,7 @@
> >
> >        /**
> >         * Save the specified messages keys into the 
> appropriate request
> >   -     * attribute for use by the &lt;struts:messages&gt; tag (if
> >   +     * attribute for use by the &lt;html:messages&gt; tag (if
> >         * messages="true" is set), if any messages are required.
> > Otherwise,
> >         * ensure that the request attribute is not created.
> >         *
> >
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
> > <mailto:struts-dev-unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail:
> > <mailto:struts-dev-help@jakarta.apache.org>
> >
> >
> 
> 
> --
> To unsubscribe, e-mail:   
> <mailto:struts-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: 
> <mailto:struts-dev-help@jakarta.apache.org>
> 
> 


--
To unsubscribe, e-mail:   <mailto:struts-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:struts-dev-help@jakarta.apache.org>


Mime
View raw message