struts-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Winterfeldt <dwinterfe...@yahoo.com>
Subject Re: /contrib
Date Sat, 07 Jul 2001 20:16:24 GMT

--- Ted Husted <husted@apache.org> wrote:
> I don't have access to the CVS permission list, and
> can't check on how
> you're setup myself. I could ask root, or wait for
> Craig to get back. 
> 
> I did commit a file to the contrib root, and did a
> fresh checkout to be
> sure it made the round trip. 
> 
> If you have a chance, see if you can commit some
> change to the README in
> /contrib, and also try the others again.
> 
> One thing we can discuss now is whether the
> ValidatorForm should be part
> of the core distribution, or a standard option.
> 
> At this point, personally I wouldn't dream of
> writing a Struts app
> without the ValidatorForm ;-), and it wouldn't take
> much to convince me
> that it should live under shared with the core
> distribution. On the
> other hand, if we can load the validations as a
> "Struts Extension", it
> would also be a great example of how a "standard
> option" can work.
I don't know.  I could go either way.  I think it
makes sense having the ValidatorForm in
org.apache.struts.action.  Although having it setup as
an extension might provide more flexibility going into
the future.  I was personally thinking of trying to
keep the dependencies on Struts minimized, but the
Struts specific interfaces would go somewhere in the
core (like ValidatorForm).

> 
> Also there is the question of whether we should
> update the html:error
> tags to use the Validator versions (+1 for me).
Are there any issues with breaking backwards
compatibility?  I'm for replacing the validator
version for the current since iterating throught the
errors further encourages formatting to be in the
view.  If we do replace the old tag, would it still be
somewhere for people to access the old tag that
migrate from Struts 1.0 to Struts 1.1?  Possibly
called html:errorsOld or old-html:errors.  Or the new
one could be html:errorsIterator.

David

> 
> David Winterfeldt wrote:
> > 
> > I started to check everything into a validator
> > directory under contrib.  It looks like I
> successfully
> > added directories, but I get this error when
> checking
> > in a file.  I checked in one of the documentation
> xsl
> > files a few days ago and that didn't cause a
> problem.
> > Has anyone seen these error messages before?  Do I
> not
> > have write permission in the cvs logs?
> > 
> > cvs add: cannot add special file `CVS'; skipping
> > cvs add: scheduling file `INSTALL' for addition
> > cvs add: scheduling file `LICENSE' for addition
> > cvs add: scheduling file `README' for addition
> > cvs add: scheduling file `build-test.xml' for
> addition
> > cvs add: scheduling file `build.properties' for
> > addition
> > cvs add: scheduling file `build.xml' for addition
> > Cannot open
> > /home/cvspublic/CVSROOT/commitlogs/jakarta-struts:
> > Permission denied
> > Mailing the commit message...
> > Directory
> >
>
/home/cvspublic/jakarta-struts/contrib/validator/conf
> > added to the repository
> > Cannot open
> > /home/cvspublic/CVSROOT/commitlogs/jakarta-struts:
> > Permission denied
> > Mailing the commit message...
> > 
> > I ran 'cvs add' first.
> > cvs ci INSTALL
> > **** Access denied: Insufficient Karma
> > (dwinterfeldt|jakarta-struts/contrib/validator)
> > cvs commit: Pre-commit check failed
> > cvs [commit aborted]: correct above errors first!
> > 
> > The status shows it checked in locally, but not
> into
> > the main repository.
> > 
> > David


__________________________________________________
Do You Yahoo!?
Get personalized email addresses from Yahoo! Mail
http://personal.mail.yahoo.com/

Mime
View raw message