Return-Path: Delivered-To: apmail-jakarta-struts-dev-archive@jakarta.apache.org Received: (qmail 30958 invoked by uid 500); 1 Jun 2001 21:24:58 -0000 Mailing-List: contact struts-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk Reply-To: struts-dev@jakarta.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list struts-dev@jakarta.apache.org Received: (qmail 30951 invoked from network); 1 Jun 2001 21:24:57 -0000 Received: from unknown (HELO exchange.tallan.com) (12.33.112.231) by h31.sny.collab.net with SMTP; 1 Jun 2001 21:24:57 -0000 Received: by exchange.net.tallan.com with Internet Mail Service (5.5.2653.19) id ; Fri, 1 Jun 2001 17:21:25 -0400 Received: from BDSHDEADMAN ([10.0.71.233]) by exchange.tallan.com with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2653.13) id K81D483Q; Fri, 1 Jun 2001 17:21:20 -0400 From: "Deadman, Hal" To: struts-dev@jakarta.apache.org Subject: RE: cvs commit: jakarta-struts/src/share/org/apache/struts/util RequestUtils.java Date: Fri, 1 Jun 2001 17:27:02 -0400 Message-ID: <000601c0eae1$a0a65390$e947000a@bdshdeadman> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook CWS, Build 9.0.2416 (9.0.2911.0) Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4522.1200 In-Reply-To: <20010601202141.37179.qmail@apache.org> X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N Does this change mean that there will be a link generated that looks like this: some.jsp?test=1&test=2 instead of some.jsp?test=1&test=2 If so, I don't think that will work. It doesn't work on Weblogic 6.0. Calling getParameterValues() only sees the first value. Hal > -----Original Message----- > From: craigmcc@apache.org [mailto:craigmcc@apache.org] > Sent: Friday, June 01, 2001 4:22 PM > To: jakarta-struts-cvs@apache.org > Subject: cvs commit: jakarta-struts/src/share/org/apache/struts/util > RequestUtils.java > > > craigmcc 01/06/01 13:21:41 > > Modified: src/share/org/apache/struts/util Tag: STRUTS_1_0_BRANCH > RequestUtils.java > Log: > Generate "&" instead of "&" in request URIs so that the > output is still > legal XML syntax in the value returned by computeURL(). > > PR: Bugzilla #1938 > Submitted by : Alessandro Vernet (also supplied > the patch - thanks!) > > Revision Changes Path > No revision > > > No revision > > > 1.14.2.2 +7 -7 > jakarta-struts/src/share/org/apache/struts/util/RequestUtils.java > > Index: RequestUtils.java > =================================================================== > RCS file: > /home/cvs/jakarta-struts/src/share/org/apache/struts/util/Requ > estUtils.java,v > retrieving revision 1.14.2.1 > retrieving revision 1.14.2.2 > diff -u -r1.14.2.1 -r1.14.2.2 > --- RequestUtils.java 2001/06/01 18:45:03 1.14.2.1 > +++ RequestUtils.java 2001/06/01 20:21:40 1.14.2.2 > @@ -1,7 +1,7 @@ > /* > - * $Header: > /home/cvs/jakarta-struts/src/share/org/apache/struts/util/Requ > estUtils.java,v 1.14.2.1 2001/06/01 18:45:03 craigmcc Exp $ > - * $Revision: 1.14.2.1 $ > - * $Date: 2001/06/01 18:45:03 $ > + * $Header: > /home/cvs/jakarta-struts/src/share/org/apache/struts/util/Requ > estUtils.java,v 1.14.2.2 2001/06/01 20:21:40 craigmcc Exp $ > + * $Revision: 1.14.2.2 $ > + * $Date: 2001/06/01 20:21:40 $ > * > * > ==================================================================== > * > @@ -95,7 +95,7 @@ > * in the Struts controller framework. > * > * @author Craig R. McClanahan > - * @version $Revision: 1.14.2.1 $ $Date: 2001/06/01 18:45:03 $ > + * @version $Revision: 1.14.2.2 $ $Date: 2001/06/01 20:21:40 $ > */ > > public class RequestUtils { > @@ -364,7 +364,7 @@ > url.append('?'); > question = true; > } else > - url.append('&'); > + url.append("&"); > url.append(URLEncoder.encode(key)); > url.append('='); // Interpret null as > "no value" > } else if (value instanceof String) { > @@ -372,7 +372,7 @@ > url.append('?'); > question = true; > } else > - url.append('&'); > + url.append("&"); > url.append(URLEncoder.encode(key)); > url.append('='); > url.append(URLEncoder.encode((String) value)); > @@ -383,7 +383,7 @@ > url.append('?'); > question = true; > } else > - url.append('&'); > + url.append("&"); > url.append(URLEncoder.encode(key)); > url.append('='); > url.append(URLEncoder.encode(values[i])); > > > >