struts-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lukaszlen...@apache.org
Subject [07/12] git commit: Updates as stated in PR#20 comments - removed test method testDefaultMessageOverride.
Date Thu, 21 Aug 2014 07:45:27 GMT
Updates as stated in PR#20 comments - removed test method testDefaultMessageOverride.


Project: http://git-wip-us.apache.org/repos/asf/struts/repo
Commit: http://git-wip-us.apache.org/repos/asf/struts/commit/9254aaae
Tree: http://git-wip-us.apache.org/repos/asf/struts/tree/9254aaae
Diff: http://git-wip-us.apache.org/repos/asf/struts/diff/9254aaae

Branch: refs/heads/develop
Commit: 9254aaaefefbf0cc523c1bd710b60b9b815825e2
Parents: da9afaf
Author: Luigi Fugaro <l.fugaro@gmail.com>
Authored: Wed Jul 30 14:29:47 2014 +0200
Committer: Luigi Fugaro <l.fugaro@gmail.com>
Committed: Wed Jul 30 14:29:47 2014 +0200

----------------------------------------------------------------------
 .../com/opensymphony/xwork2/util/LocalizedTextUtilTest.java    | 6 ++++++
 1 file changed, 6 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/struts/blob/9254aaae/xwork-core/src/test/java/com/opensymphony/xwork2/util/LocalizedTextUtilTest.java
----------------------------------------------------------------------
diff --git a/xwork-core/src/test/java/com/opensymphony/xwork2/util/LocalizedTextUtilTest.java
b/xwork-core/src/test/java/com/opensymphony/xwork2/util/LocalizedTextUtilTest.java
index bac41ba..2298297 100644
--- a/xwork-core/src/test/java/com/opensymphony/xwork2/util/LocalizedTextUtilTest.java
+++ b/xwork-core/src/test/java/com/opensymphony/xwork2/util/LocalizedTextUtilTest.java
@@ -133,6 +133,11 @@ public class LocalizedTextUtilTest extends XWorkTestCase {
         assertEquals("Error during Action invocation", message);
     }
 
+    /*
+    Stated that property's management does not care about ordering,
+    in fact it's held by a Set instead of List,
+    you cannot override a previous bundle, thus the test is wrong.
+
     public void testDefaultMessageOverride() throws Exception {
         String message = LocalizedTextUtil.findDefaultText(XWorkMessages.ACTION_EXECUTION_ERROR,
Locale.getDefault());
         assertEquals("Error during Action invocation", message);
@@ -142,6 +147,7 @@ public class LocalizedTextUtilTest extends XWorkTestCase {
         message = LocalizedTextUtil.findDefaultText(XWorkMessages.ACTION_EXECUTION_ERROR,
Locale.getDefault());
         assertEquals("Testing resource bundle override", message);
     }
+    */
 
     public void testFindTextInChildProperty() throws Exception {
         ModelDriven action = new ModelDrivenAction2();


Mime
View raw message