struts-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bphill...@apache.org
Subject svn commit: r1553827 - /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
Date Sat, 28 Dec 2013 14:08:49 GMT
Author: bphillips
Date: Sat Dec 28 14:08:48 2013
New Revision: 1553827

URL: http://svn.apache.org/r1553827
Log:
Fix issue where if parameter name is greater then max parameter name length a log error is
written when devMode is false - see:  https://issues.apache.org/jira/browse/WW-4264

Modified:
    struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java

Modified: struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
URL: http://svn.apache.org/viewvc/struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java?rev=1553827&r1=1553826&r2=1553827&view=diff
==============================================================================
--- struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
(original)
+++ struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
Sat Dec 28 14:08:48 2013
@@ -166,7 +166,7 @@ public class ParametersInterceptor exten
 
     @Inject(XWorkConstants.DEV_MODE)
     public void setDevMode(String mode) {
-        devMode = "true".equals(mode);
+        devMode = "true".equalsIgnoreCase(mode);
     }
 
 	/**
@@ -329,7 +329,7 @@ public class ParametersInterceptor exten
                 newStack.setParameter(name, value);
             } catch (RuntimeException e) {
                 if (devMode) {
-                    notifyDeveloper(action, name, e.getMessage());
+                    notifyDeveloperParameterException(action, name, e.getMessage());
                 }
             }
         }
@@ -340,7 +340,7 @@ public class ParametersInterceptor exten
         addParametersToContext(ActionContext.getContext(), acceptableParameters);
     }
 
-    protected void notifyDeveloper(Object action, String property, String message) {
+    protected void notifyDeveloperParameterException(Object action, String property, String
message) {
         String developerNotification = LocalizedTextUtil.findText(ParametersInterceptor.class,
"devmode.notification",
                 ActionContext.getContext().getLocale(), "Developer Notification:\n{0}",
                 new Object[]{



Mime
View raw message