streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Blackmon <sblack...@apache.org>
Subject Re: [CANCEL] [VOTE] Release Apache Streams 0.6.0 (RC1)
Date Mon, 11 Jun 2018 18:55:44 GMT
 I merged the open PRs addressing the problems with rc1 this morning, and
jenkins is blue again - https://builds.apache.org/job/streams-project/461/

Steve

Sent from Astro <https://www.helloastro.com> for Mac

On Jun 2, 2018 at 12:39 PM, Joey Frazee <joey.frazee@icloud.com> wrote:


Because of the build issue identified by Steve [1] I’m cancelling the vote
on RC1. I’ll put up another RC as soon as we get appropriate fixes/PRs in.

-joey

1.
https://lists.apache.org/thread.html/a855ea3ddb0b4395ff54b852884457429e0a6b41dc35ea0ce47a3ab7@%3Cdev.streams.apache.org%3E
On Jun 2, 2018, 11:37 AM -0500, Steve Blackmon <sblackmon@apache.org>,
wrote:

I tried using the maven:latest image on docker hub, which package the
newest maven and open-jdk versions on a debian base
https://hub.docker.com/_/maven/

Specifically:
steves-mac-pro:~ steve$ docker run -it maven:latest mvn -v
Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297;
2018-02-24T19:49:05Z)
Maven home: /usr/share/maven
Java version: 1.8.0_171, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en, platform encoding: UTF-8
OS name: "linux", version: "4.9.87-linuxkit-aufs", arch: "amd64", family:
“unix"

The docker environment failed at the same point originally raised:
steves-mac-pro:~ steve$ docker run -it -w /usr/src/mymaven -v
/Users/steve/apache-streams-0.6.0:/usr/src/mymaven maven:latest mvn clean
install
…
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test)
on project streams-schema-activitystreams: ExecutionException
org.apache.maven.surefire.util.internal.StringUtils.requireNonNull(Ljava/lang/Object;)Ljava/lang/Object;
-> [Help 1]

The docker environment, and my local environment, and my local environment
updated to the newest JDK and maven, built successfully with the surefire
plugin version bump incorporated.

With regard to BroadcastMessagePersisterTest - it seems plausible that the
way url.com handles requests to unregistered symbols may have changed
overnight.

I would support a more resilient improvement to the test in lieu of the
quick fix in the open PR - or we can just disabe that test for this release
and put in mocks for internet calls in this and other tests afterward.

If we get to +3 without me, I’ll switch to +0 - as I don’t think either or
these problems impact the functionality of the release at all, they just
interfere with the build process.

Steve

On Jun 2, 2018 at 10:57 AM, Joey Frazee <joey.frazee@icloud.com> wrote:


Steve, can you try running it with a more recent version of the JDK? Like
1.8.0_151 or later to see if that has any impact on the surefire piece?
Seems unlikely but I've seen lots of build issues on the older JDKs.

So, I had packaged this earlier and had been fighting with Nexus, so are
you saying that in the interim the domain got registered? Just trying to
understand.

I think the test fix could be better. I'd expect the same could pop up with
url.com. Should we mock this with wire mock or point it at something we
expect to never go away?

-joey

On Jun 2, 2018, at 10:02 AM, Steve Blackmon <sblackmon@apache.org> wrote:

-1 binding… TL;DR failing unit tests that require changes to project
artifacts to overcome. PR coming.

——

I ran into problems building on my mac with mvn -v:

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T10:41:47-06:00)
Maven home: /Users/Shared/apache-maven-3.3.9
Java version: 1.8.0_111, vendor: Oracle Corporation
Java home:
/Library/Java/JavaVirtualMachines/jdk1.8.0_111.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.13.4", arch: "x86_64", family: "mac"

Failure was:

[INFO] streams-schema-activitystreams ..................... FAILURE [
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test)
on project streams-schema-activitystreams: ExecutionException
org.apache.maven.surefire.util.internal.StringUtils.requireNonNull(Ljava/lang/Object;)Ljava/lang/Object;
-> [Help 1]

What’s curious about this error is it originates outside our test code in
this module.

On a hunch I upgraded ${surefire.plugin.version} to latest version in
pom.xml and that fixed it.

Also encountered one other failing test caused by changes outside our
control.

org.apache.streams.monitoring.persist.impl.BroadcastMessagePersisterTest.testFailedPersist()
contains a URL that has begun returning a 200 with body “Not Found!”
instead of a 404.

Changing the URL to point at a non-registered domain instead of at
url.com got me through this problem.

——

I’ll submit these changes as two PRs shortly. If anyone can suggest a
way I can see all the unit tests pass without touching project
artifacts I’ll change my vote but I doubt that is possible.

Steve


On May 31, 2018 at 7:42 PM, Suneel Marthi <smarthi@apache.org> wrote:


+1 binding

1. Verified checksums and sigs
2. Downloaded src archive and did a clean build - all tests pass


Please remove the MD5 sigs when finalizing the release.

On Thu, May 31, 2018 at 6:27 PM, Joey Frazee <joey.frazee@icloud.com> wrote:

I am pleased to be calling a vote for the release of Apache Streams 0.6.0.
Apache Streams 0.6.0 includes the following fixes and improvements:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?
projectId=12314320&version=12342993

This release candidate is based on streams-0.6.0-RC1 (3a57c3c):

https://github.com/apache/streams/releases/tag/streams-0.6.0-RC1
https://gitbox.apache.org/repos/asf?p=streams.git;a=commit;h=
3a57c3c3a845b1e64c37303cb3aaa742cfa2185f

The release candidate source archive, signatures and digests are at:

https://repository.apache.org/content/repositories/
orgapachestreams-1027/org/apache/streams/apache-streams/0.6.0/

And, the full staging repo and release artifacts can be found here:

https://repository.apache.org/content/repositories/
orgapachestreams-1027/

The release artifacts have been signed with https://people.apache.org/
keys/committer/jfrazee.asc and the project KEYS file can be found at
https://raw.githubusercontent.com/apache/streams/master/KEYS

Git ID: 3a57c3c3a845b1e64c37303cb3aaa742cfa2185f
MD5: 052d4c081cf62b6262a56b16729aa6b2
SHA1: 8fbe605ca4fa0e0abeef43cc0977a642b1c6761a

See streams/release.sh for information on how to build and run with
integration tests.

The vote will be open for at least 72 hours.

[ ] +1 approve the release of Apache Streams 0.6.0
[ ] +0 no opinion (and reason why)
[ ] -1 disapprove (and reason why)

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message