From dev-return-4587-archive-asf-public=cust-asf.ponee.io@streams.apache.org Sat Jan 20 19:40:38 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id E201618066D for ; Sat, 20 Jan 2018 19:40:38 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D14DF160C38; Sat, 20 Jan 2018 18:40:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 21A2E160C28 for ; Sat, 20 Jan 2018 19:40:37 +0100 (CET) Received: (qmail 26994 invoked by uid 500); 20 Jan 2018 18:40:37 -0000 Mailing-List: contact dev-help@streams.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@streams.apache.org Delivered-To: mailing list dev@streams.apache.org Received: (qmail 26983 invoked by uid 99); 20 Jan 2018 18:40:37 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 20 Jan 2018 18:40:37 +0000 Received: from mail-io0-f171.google.com (mail-io0-f171.google.com [209.85.223.171]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 70ABB1A0044 for ; Sat, 20 Jan 2018 18:40:35 +0000 (UTC) Received: by mail-io0-f171.google.com with SMTP id f4so3690130ioh.8 for ; Sat, 20 Jan 2018 10:40:35 -0800 (PST) X-Gm-Message-State: AKwxyteJ1RaWqPbSdF8QgROgFB8Yiz23PREqDdQzRk0++mZ1rraYF4QW 2NnANIWjsqoBuzW9dmmrFB8qIs9xr8dMhdcT6B02XQ== X-Google-Smtp-Source: AH8x225wR5Yw5fE69vR93NNT1kQnIt0RGXBa+8soDPiGc+vFWuuY6gpTtVHm0LjsZSbD/vFwnh8MKCwz794oslJOz7c= X-Received: by 10.107.149.149 with SMTP id x143mr2718349iod.194.1516473633359; Sat, 20 Jan 2018 10:40:33 -0800 (PST) Received: from 661309549932 named unknown by gmailapi.google.com with HTTPREST; Sat, 20 Jan 2018 10:40:32 -0800 From: Steve Blackmon In-Reply-To: <7d5ab653-8365-453d-a64f-a1a19e6cd3ba@astromail.ai> References: <00ab3e2a-9169-dcc8-8b0b-f93f6edcce34@douma.nu> <7d5ab653-8365-453d-a64f-a1a19e6cd3ba@astromail.ai> MIME-Version: 1.0 Date: Sat, 20 Jan 2018 10:40:32 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: UPDATE: Consolidate Example modules with Project Repo To: dev@streams.apache.org Content-Type: multipart/alternative; boundary="001a1140c72a3a61050563398899" --001a1140c72a3a61050563398899 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable STREAMS-574 has been merged. streams.apache.org Examples section is populated again. github.com/apache/streams-examples/README.md has been updated with a migration notice. no requests for deletion have been submitted - just in case we want access to the full git history. Steve On Jan 16, 2018 at 12:12 PM, Steve Blackmon wrote: On Jan 16, 2018 at 3:57 AM, Ate Douma wrote: On 2018-01-16 05:58, Steve Blackmon wrote: Has anyone had a chance to take a look? I=E2=80=99m content with this change-set, and I am planning to lazy consens= us merge in 48 hours. Following that I=E2=80=99ll ask infra to delete the legacy streams-examples= repo in git asf gitbox and github. If I understand this correctly, you just *copied* the current examples files, right? That means that all commit history in the streams-example repo, once deleted, will be gone as well. Not sure I or anyone cares, just want to make sure this is the intent? Ate That=E2=80=99s correct. This will effectively squash all the commits in streams-examples into a single commit in a sub-module of apache-streams. I suppose there=E2=80=99s no pressing need to delete the streams-examples r= epo right away, other than to avoid user confusion, which could be mitigated with a deprecation notice and at the top of the root README. Steve Steve On Jan 10, 2018 at 12:16 AM, Steve Blackmon wrote: Having received three +1 and no objections, I took the liberty of creating STREAMS-574 ticket and opening a pull request. https://issues.apache.org/jira/browse/STREAMS-574 https://github.com/apache/streams/pull/417 It=E2=80=99s a straight lift-and-shift from apache/streams-examples into a sub-module of apache/streams. The only changes made in transit were trivial, not worth enumerating, and necessary to get the ITs passing. One module - twitter-follow-neo4j - looks to some additional work to get the ITs passing, so I=E2=80=99ve removed it from the reactor (temporarily) = in this PR. Please take a look at your leisure. Steve On Jan 9, 2018 at 11:12 AM, Steve Blackmon wrote: I think we would compile examples with every pull request and merge to master, and run examples integration tests along with the rest of the ITs in the streams-project-verify jenkins job (and as a step in the release process like you mentioned.) We=E2=80=99re now at the point where we need to start categorizing our inte= gration tests more finely and giving the developer more control over which run - this is because some integration tests require credentials with special permissions that not every developer will have access to. I think we can fit the examples into that scheme however is appropriate, while also making their execution conditional on a separate profile disabled by default. Steve Sent from Astro for Mac On Jan 9, 2018 at 10:24 AM, Joey Frazee wrote: +1 Is the plan to have them be part of every build or to use an optional build profile? I=E2=80=99m partial to the latter; that said, I could see the argu= ment wanting whatever the clean install is to be how we build and test for an Apache release since we will now need those to be voted on for every release. -joey On Jan 8, 2018, 1:44 PM -0700, Trevor Grant , wrote: +1 On Mon, Jan 8, 2018 at 2:27 PM, Suneel Marthi wrote: +1 On Mon, Jan 8, 2018 at 3:26 PM, Steve Blackmon