Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@streams.incubator.apache.org
From: Joey Frazee <joey.frazee@icloud.com>
Content-type: multipart/alternative;
 boundary=Apple-Mail-0046AC18-C59A-4589-8551-692A36FF3E1B
Content-transfer-encoding: 7bit
MIME-version: 1.0 (1.0)
Date: Sun, 23 Oct 2016 09:09:31 -0500
Subject: Re: Submitting and Handling Github PRs
Message-id: <1113B3A4-C818-4EB7-A08A-59AEBF1DA2A2@icloud.com>
References: 
 <CAOtpBjhDWEGKjC6za8agH2OhkrTLT_6QmWeM8MKwSWmx7gTwUA@mail.gmail.com>
 <etPan.580bd40c.18a97d24.824@apache.org>
 <A9C9DAF8-BA47-4A65-9AD9-963FD5A51562@hortonworks.com>
In-reply-to: <A9C9DAF8-BA47-4A65-9AD9-963FD5A51562@hortonworks.com>
To: dev@streams.incubator.apache.org
archived-at: Sun, 23 Oct 2016 14:09:59 -0000

--Apple-Mail-0046AC18-C59A-4589-8551-692A36FF3E1B
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable

I've seen some use of Github PR comment templates/pre-filled forms to remind=
 the submitter to do all the necessary stuff:

- JIRA issue opened
- JIRA issue in the title
- Run contrib-check
- Link to Apache CLA form
- Anything else?

It's a nice place to put the info since it's not uncommon for people to star=
t contributing without ever checking whatever guidelines are in place.

I think this is another infra task though?

> On Oct 22, 2016, at 4:13 PM, Timothy Spann <tspann@hortonworks.com> wrote:=

>=20
> That is very helpful
>=20
>=20
> On 10/22/16, 5:03 PM, "sblackmon" <sblackmon@apache.org> wrote:
>=20
>    That=E2=80=99s a nice PR tutorial page.  We should add one like it to t=
he streams website.
>=20
>    +1 to squashing and referencing JIRA on every commit message as common p=
ractice - should make it easier to follow what=E2=80=99s happened on master b=
ranch.
>=20
>    Steve
>    On October 22, 2016 at 3:57:54 PM, Suneel Marthi (smarthi@apache.org) w=
rote:
>=20
>    Wanted to bring up 2 things about managing PRs: =20
>=20
>    1. Squash all commits before merging PRs to master =20
>=20
>    2. Include the jira in the final commit before merging to master =20
>=20
>    Most projects (TLP and Incubator) do it - Mahout, Flink, Pirk, Predicti=
onIO. =20
>=20
>    For reference, see =20
>=20
>    https://mahout.apache.org/developers/github.html for how its being done=
 on =20
>    Mahout. =20
>=20
>=20

--Apple-Mail-0046AC18-C59A-4589-8551-692A36FF3E1B--