streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sblackmon <sblack...@apache.org>
Subject Re: Submitting and Handling Github PRs
Date Sat, 22 Oct 2016 21:03:07 GMT
That’s a nice PR tutorial page.  We should add one like it to the streams website.

+1 to squashing and referencing JIRA on every commit message as common practice - should make
it easier to follow what’s happened on master branch.

Steve
On October 22, 2016 at 3:57:54 PM, Suneel Marthi (smarthi@apache.org) wrote:

Wanted to bring up 2 things about managing PRs:  

1. Squash all commits before merging PRs to master  

2. Include the jira in the final commit before merging to master  

Most projects (TLP and Incubator) do it - Mahout, Flink, Pirk, PredictionIO.  

For reference, see  

https://mahout.apache.org/developers/github.html for how its being done on  
Mahout.  

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message