Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@streams.incubator.apache.org
Date: Mon, 30 Nov 2015 21:51:11 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@streams.incubator.apache.org
Message-ID: <JIRA.12916196.1448468217000.225046.1448920271002@Atlassian.JIRA>
In-Reply-To: <JIRA.12916196.1448468217000@Atlassian.JIRA>
References: <JIRA.12916196.1448468217000@Atlassian.JIRA>
 <JIRA.12916196.1448468217606@arcas>
Subject: [jira] [Commented] (STREAMS-385) ActivityObjectConverter
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/STREAMS-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032548#comment-15032548 ] 

ASF GitHub Bot commented on STREAMS-385:
----------------------------------------

Github user jfrazee commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/273#discussion_r46209072
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/converter/TwitterJsonUserActivityObjectConverter.java ---
    @@ -0,0 +1,64 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.streams.twitter.converter;
    +
    +import com.google.common.collect.Lists;
    +import org.apache.commons.lang.NotImplementedException;
    +import org.apache.streams.data.ActivityConverter;
    +import org.apache.streams.data.ActivityObjectConverter;
    +import org.apache.streams.exceptions.ActivityConversionException;
    +import org.apache.streams.pojo.json.Activity;
    +import org.apache.streams.pojo.json.ActivityObject;
    +import org.apache.streams.twitter.pojo.User;
    +
    +import java.util.List;
    +
    +import static org.apache.streams.twitter.converter.util.TwitterActivityUtil.buildActor;
    +import static org.apache.streams.twitter.converter.util.TwitterActivityUtil.updateActivity;
    +
    +public class TwitterJsonUserActivityObjectConverter implements ActivityObjectConverter<User> {
    +
    +    public static Class requiredClass = User.class;
    +
    +    @Override
    +    public Class requiredClass() {
    +        return requiredClass;
    +    }
    +
    +    private static TwitterJsonUserActivityObjectConverter instance = new TwitterJsonUserActivityObjectConverter();
    +
    +    public static TwitterJsonUserActivityObjectConverter getInstance() {
    +        return instance;
    +    }
    +
    +    @Override
    +    public String serializationFormat() {
    +        return null;
    +    }
    +
    +    @Override
    +    public User fromActivityObject(ActivityObject deserialized) throws ActivityConversionException {
    --- End diff --
    
    Shouldn't this be implemented? New story to do that?


> ActivityObjectConverter
> -----------------------
>
>                 Key: STREAMS-385
>                 URL: https://issues.apache.org/jira/browse/STREAMS-385
>             Project: Streams
>          Issue Type: New Feature
>            Reporter: Steve Blackmon
>            Assignee: Steve Blackmon
>
> The ActivityConverter interface and ActivityConverter{Util, Processor} classes in streams-converter allow modules to register classes to assist in conversion of non-activity event streams to activity event streams.
> This framework could also be applied to convert streams of external entities to/from ActivityObject.
> Add this interface, implement helper classes, and update at least one module to use it.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)