Return-Path: X-Original-To: apmail-streams-dev-archive@minotaur.apache.org Delivered-To: apmail-streams-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 91B56185BB for ; Mon, 19 Oct 2015 19:20:07 +0000 (UTC) Received: (qmail 29805 invoked by uid 500); 19 Oct 2015 19:20:07 -0000 Delivered-To: apmail-streams-dev-archive@streams.apache.org Received: (qmail 29767 invoked by uid 500); 19 Oct 2015 19:20:07 -0000 Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@streams.incubator.apache.org Delivered-To: mailing list dev@streams.incubator.apache.org Received: (qmail 29754 invoked by uid 99); 19 Oct 2015 19:20:07 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Oct 2015 19:20:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CDB5BC2946 for ; Mon, 19 Oct 2015 19:20:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.982 X-Spam-Level: X-Spam-Status: No, score=0.982 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id zmizZXfX6ipc for ; Mon, 19 Oct 2015 19:19:59 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id 843F743B05 for ; Mon, 19 Oct 2015 19:19:58 +0000 (UTC) Received: (qmail 29711 invoked by uid 99); 19 Oct 2015 19:19:58 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Oct 2015 19:19:58 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C00FBE049D; Mon, 19 Oct 2015 19:19:57 +0000 (UTC) From: steveblackmon To: dev@streams.incubator.apache.org Reply-To: dev@streams.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-streams pull request: resolves STREAMS-371 Content-Type: text/plain Message-Id: <20151019191957.C00FBE049D@git1-us-west.apache.org> Date: Mon, 19 Oct 2015 19:19:57 +0000 (UTC) Github user steveblackmon commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/263#discussion_r42413877 --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterFollowingProvider.java --- @@ -129,7 +134,7 @@ public StreamsResultSet readCurrent() { @Override public void prepare(Object o) { --- End diff -- It's delegating prepare() to it's parent class and opting to use the configuration provided by the constructor rather than by the streams runtime. prepare(Object) is defined by the interface and thus has to be implemented, but exact implementation details vary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---