Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@streams.incubator.apache.org
From: eponvert <git@git.apache.org>
To: dev@streams.incubator.apache.org
Reply-To: dev@streams.incubator.apache.org
References: <git-pr-262-incubator-streams@git.apache.org>
In-Reply-To: <git-pr-262-incubator-streams@git.apache.org>
Subject: [GitHub] incubator-streams pull request: resolves STREAMS-370
Content-Type: text/plain
Message-Id: <20151019142712.65EFAE0286@git1-us-west.apache.org>
Date: Mon, 19 Oct 2015 14:27:12 +0000 (UTC)

Github user eponvert commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/262#discussion_r42377148
  
    --- Diff: streams-contrib/streams-persist-graph/src/main/java/org/apache/streams/graph/GraphHttpPersistWriter.java ---
    @@ -218,7 +217,7 @@ protected ObjectNode executePost(HttpPost httpPost) {
         @Override
         public void prepare(Object configurationObject) {
    --- End diff --
    
    This method effectively ignores the `configurationObject` parameter -- should the parameter be removed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---