streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jfrazee <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: resolves Streams 356
Date Wed, 02 Sep 2015 18:40:31 GMT
Github user jfrazee commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/249#discussion_r38568376
  
    --- Diff: streams-core/src/main/java/org/apache/streams/core/StreamsDatum.java ---
    @@ -51,10 +51,22 @@ public StreamsDatum(Object document, DateTime timestamp, BigInteger
sequenceid)
             this(document, null, timestamp, sequenceid);
         }
     
    +    public StreamsDatum(Object document, DateTime timestamp, Map<String, Object>
metadata) {
    +        this(document, null, timestamp, null, metadata);
    +    }
    +
         public StreamsDatum(Object document, String id, DateTime timestamp) {
             this(document, id, timestamp, null);
    --- End diff --
    
    If this is calling the constructor on line 66, then passing null for metadata is inconstant
with the empty hash in the constructors on 34 and 38.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message