streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jfrazee <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: resolves STREAMS-311 #311
Date Thu, 14 May 2015 22:55:41 GMT
Github user jfrazee commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/217#discussion_r30371934
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterFollowingProviderTask.java
---
    @@ -141,7 +141,7 @@ else if( endpoint.equals("friends") )
                 catch(Exception e) {
                     keepTrying += TwitterErrorHandler.handleTwitterError(client, e);
                 }
    -        } while (curser != 0 && keepTrying < 10);
    +        } while (curser != 0 && keepTrying < 50);
    --- End diff --
    
    I think this should be left out of this PR in favor of making the TwitterErrorHandler
respect the Twitter4j RateLimitStatus reset time. I'm volunteering to do that, so unless STREAMS-311
can't be fixed without it I'd say to put this back to 10.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message