streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From steveblackmon <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: STREAMS-231
Date Wed, 01 Apr 2015 01:57:36 GMT
Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/203#discussion_r27539716
  
    --- Diff: streams-components/streams-http/src/main/java/org/apache/streams/components/http/persist/SimpleHTTPPostPersistWriter.java
---
    @@ -113,13 +113,14 @@ protected ObjectNode preparePayload(StreamsDatum entry) {
         public HttpPost prepareHttpPost(URI uri, ObjectNode payload) {
             HttpPost httppost = new HttpPost(uri);
             httppost.addHeader("content-type", this.configuration.getContentType());
    +        httppost.addHeader("accept-charset", "UTF-8");
             try {
                 String entity = mapper.writeValueAsString(payload);
                 httppost.setEntity(new StringEntity(entity));
             } catch (JsonProcessingException e) {
    -            e.printStackTrace();
    +            LOGGER.warn(e.getMessage());
    --- End diff --
    
    i've typically used WARN when a specific datum fails to process/persist, but there's no
evidence that all future data will fail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message