Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@streams.incubator.apache.org
Date: Wed, 25 Mar 2015 17:08:53 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@streams.incubator.apache.org
Message-ID: <JIRA.12773611.1423523830000.25255.1427303333555@Atlassian.JIRA>
In-Reply-To: <JIRA.12773611.1423523830000@Atlassian.JIRA>
References: <JIRA.12773611.1423523830000@Atlassian.JIRA>
 <JIRA.12773611.1423523830788@arcas>
Subject: [jira] [Commented] (STREAMS-277) Upgrade streams-provider-twitter
 to work with reflection-based conversion
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/STREAMS-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380253#comment-14380253 ] 

ASF GitHub Bot commented on STREAMS-277:
----------------------------------------

Github user jfrazee commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/200#discussion_r27142471
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/converter/TwitterJsonRetweetActivityConverter.java ---
    @@ -0,0 +1,83 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.streams.twitter.converter;
    +
    +import com.google.common.collect.Lists;
    +import org.apache.commons.lang.NotImplementedException;
    +import org.apache.streams.data.ActivityConverter;
    +import org.apache.streams.exceptions.ActivityConversionException;
    +import org.apache.streams.pojo.json.Activity;
    +import org.apache.streams.twitter.pojo.Retweet;
    +
    +import java.io.Serializable;
    +import java.util.List;
    +
    +import static org.apache.streams.twitter.converter.util.TwitterActivityUtil.*;
    +
    +public class TwitterJsonRetweetActivityConverter implements ActivityConverter<Retweet>, Serializable {
    +
    +    public static Class requiredClass = Retweet.class;
    +
    +    @Override
    +    public Class requiredClass() {
    +        return requiredClass;
    +    }
    +
    +    private static TwitterJsonRetweetActivityConverter instance = new TwitterJsonRetweetActivityConverter();
    +
    +    public static TwitterJsonRetweetActivityConverter getInstance() {
    +        return instance;
    +    }
    +
    +    @Override
    +    public String serializationFormat() {
    +        return null;
    +    }
    +
    +    @Override
    +    public Retweet fromActivity(Activity deserialized) throws ActivityConversionException {
    +        return null;
    +    }
    +
    +    @Override
    +    public List<Activity> toActivityList(Retweet retweet) throws ActivityConversionException {
    +
    +        Activity activity = new Activity();
    +        updateActivity(retweet, activity);
    +
    +        return Lists.newArrayList(activity);
    +    }
    +
    +    @Override
    +    public List<Retweet> fromActivityList(List<Activity> list) {
    +        throw new NotImplementedException();
    --- End diff --
    
    This seems inconsistent with fromActivity(), which returns null instead of NotImplementedException. Also, would there be any sense to allowing a conversion on Tweet, since there are frequently Retweets embedded in them?


> Upgrade streams-provider-twitter to work with reflection-based conversion
> -------------------------------------------------------------------------
>
>                 Key: STREAMS-277
>                 URL: https://issues.apache.org/jira/browse/STREAMS-277
>             Project: Streams
>          Issue Type: Sub-task
>            Reporter: Steve Blackmon
>
> Upgrade streams-provider-twitter with StreamsDateTimeFormat, DocumentClassifier, and ActivityConverter implementations and tests.
> Additional details in parent issue.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)