Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@streams.incubator.apache.org
Date: Tue, 31 Mar 2015 23:02:53 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@streams.incubator.apache.org
Message-ID: <JIRA.12762946.1419015996000.87010.1427842973105@Atlassian.JIRA>
In-Reply-To: <JIRA.12762946.1419015996000@Atlassian.JIRA>
References: <JIRA.12762946.1419015996000@Atlassian.JIRA>
 <JIRA.12762946.1419015996470@arcas>
Subject: [jira] [Commented] (STREAMS-259) Filter a stream of Activities for
 specific verbs and objectTypes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/STREAMS-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389582#comment-14389582 ] 

ASF GitHub Bot commented on STREAMS-259:
----------------------------------------

Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/207#discussion_r27531716
  
    --- Diff: streams-verbs/src/main/java/org/apache/streams/verbs/VerbDefinitionResolver.java ---
    @@ -0,0 +1,112 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.streams.verbs;
    +
    +import com.google.common.collect.Lists;
    +import com.google.common.collect.Sets;
    +import org.apache.streams.pojo.json.Activity;
    +import org.apache.streams.pojo.json.ActivityObject;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.util.*;
    +
    +public class VerbDefinitionResolver {
    +
    +    private static final Logger LOGGER = LoggerFactory.getLogger(VerbDefinitionResolver.class);
    +
    +    protected Set<VerbDefinition> verbDefinitionSet;
    +
    +    public VerbDefinitionResolver() {
    +        // get with reflection
    +    }
    +
    +    public VerbDefinitionResolver(Set<VerbDefinition> verbDefinitionSet) {
    +        this();
    +        this.verbDefinitionSet = verbDefinitionSet;
    +    }
    +
    +    public List<VerbDefinition> matchingVerbDefinitions(Activity activity) {
    +
    +        Set<VerbDefinition> candidates = Sets.newConcurrentHashSet(verbDefinitionSet);
    --- End diff --
    
    good catch.  fixed in latest push.


> Filter a stream of Activities for specific verbs and objectTypes
> ----------------------------------------------------------------
>
>                 Key: STREAMS-259
>                 URL: https://issues.apache.org/jira/browse/STREAMS-259
>             Project: Streams
>          Issue Type: New Feature
>            Reporter: Steve Blackmon
>            Assignee: Steve Blackmon
>
> Provide a way to define and apply a filter to a stream to pass along only activities with defined verbs and objectTypes in specific fields.
> Verb Definitions appear to be a good way to specify and identify filtering rules.
> https://raw.github.com/activitystreams/activity-streams-verb-definition/master/activity-streams-verb-definition.txt


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)