streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-277) Upgrade streams-provider-twitter to work with reflection-based conversion
Date Tue, 24 Mar 2015 23:31:52 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378926#comment-14378926
] 

ASF GitHub Bot commented on STREAMS-277:
----------------------------------------

GitHub user steveblackmon opened a pull request:

    https://github.com/apache/incubator-streams/pull/200

    STREAMS-277 (+STREAMS-278)

    updates to make this module use DocumentClassifier and ActivityConverter interfaces and
reflection-based DateTime handling and Activity conversion.
    tweaks and renames to the tests to match the new model.
    
    This change impacts testing in streams-runtime-pig, so #179 has been merged into this
branch.
    
    Note that this will be a breaking change to streams components and pipelines which rely
on 'Serializer'-style conversion. The good news is resolving should be as simple as:
    
    ActivityConverterProcessor converter = new ActivityConverterProcessor();
    builder.addStreamsProcessor("converter", converter, 4, "provider");
    where upstream provider passes in String or ObjectNode representations of POJOs in com.twitter
    
    TwitterEventClassifier and TwitterEventProcessor are no longer necessary.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/steveblackmon/incubator-streams STREAMS-277

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-streams/pull/200.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #200
    
----
commit db5b1999d5749b05c62ca8ecd0ab1eb6a7d0080a
Author: sblackmon <sblackmon@w2odigital.com>
Date:   2015-02-10T21:37:59Z

    resolves STREAMS-278
    note that pigconvertertest.pig now uses StreamsProcessDatumExec rather than StreamsSerializerExec
which has been deleted.

commit a3240c84e1dd4988b6ffdc606a5c991cd5ddc34f
Author: sblackmon <sblackmon@w2odigital.com>
Date:   2015-02-10T21:41:51Z

    added AL headers to test scripts

commit 2cc6118f17aaaaa0ced4ea35f3910f90b05b0889
Author: sblackmon <sblackmon@w2odigital.com>
Date:   2015-02-10T21:35:34Z

    updates to make this module use DocumentClassifier and ActivityConverter interfaces and
reflection-based DateTime handling and Activity conversion.
    tweaks and renames to the tests to match the new model.
    this change impacts testing in streams-runtime-pig, so PR submitted for STREAMS-278 must
merge first.
    resolves STREAMS-276

commit a57d0311b1f38a994c23ee18f399c469f2ecdc6f
Author: Steve Blackmon (@steveblackmon) <sblackmon@apache.org>
Date:   2015-03-24T23:25:24Z

    Merge branch 'STREAMS-278' into STREAMS-277

----


> Upgrade streams-provider-twitter to work with reflection-based conversion
> -------------------------------------------------------------------------
>
>                 Key: STREAMS-277
>                 URL: https://issues.apache.org/jira/browse/STREAMS-277
>             Project: Streams
>          Issue Type: Sub-task
>            Reporter: Steve Blackmon
>
> Upgrade streams-provider-twitter with StreamsDateTimeFormat, DocumentClassifier, and
ActivityConverter implementations and tests.
> Additional details in parent issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message