streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-231) Basic Neo4j graph persistence
Date Tue, 31 Mar 2015 15:42:52 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388725#comment-14388725
] 

ASF GitHub Bot commented on STREAMS-231:
----------------------------------------

Github user jfrazee commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/203#discussion_r27491480
  
    --- Diff: streams-components/streams-http/src/main/java/org/apache/streams/components/http/persist/SimpleHTTPPostPersistWriter.java
---
    @@ -113,13 +113,14 @@ protected ObjectNode preparePayload(StreamsDatum entry) {
         public HttpPost prepareHttpPost(URI uri, ObjectNode payload) {
             HttpPost httppost = new HttpPost(uri);
             httppost.addHeader("content-type", this.configuration.getContentType());
    +        httppost.addHeader("accept-charset", "UTF-8");
             try {
                 String entity = mapper.writeValueAsString(payload);
                 httppost.setEntity(new StringEntity(entity));
             } catch (JsonProcessingException e) {
    -            e.printStackTrace();
    +            LOGGER.warn(e.getMessage());
    --- End diff --
    
    What's the thinking about these being warnings here? Seems like it's a bonafide error
if it fails to writeValueAsString.


> Basic Neo4j graph persistence
> -----------------------------
>
>                 Key: STREAMS-231
>                 URL: https://issues.apache.org/jira/browse/STREAMS-231
>             Project: Streams
>          Issue Type: Sub-task
>            Reporter: Steve Blackmon
>            Assignee: Steve Blackmon
>
> Implement basic Neo4j graph persistence



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message