Return-Path: X-Original-To: apmail-streams-dev-archive@minotaur.apache.org Delivered-To: apmail-streams-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5469B1061B for ; Mon, 9 Feb 2015 23:30:01 +0000 (UTC) Received: (qmail 30309 invoked by uid 500); 9 Feb 2015 23:29:56 -0000 Delivered-To: apmail-streams-dev-archive@streams.apache.org Received: (qmail 30259 invoked by uid 500); 9 Feb 2015 23:29:56 -0000 Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@streams.incubator.apache.org Delivered-To: mailing list dev@streams.incubator.apache.org Received: (qmail 30247 invoked by uid 99); 9 Feb 2015 23:29:56 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Feb 2015 23:29:56 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 09 Feb 2015 23:29:54 +0000 Received: (qmail 28123 invoked by uid 99); 9 Feb 2015 23:29:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Feb 2015 23:29:34 +0000 Date: Mon, 9 Feb 2015 23:29:34 +0000 (UTC) From: "Steve Blackmon (JIRA)" To: dev@streams.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (STREAMS-276) Upgrade providers to supply StreamsDateTimeFormat, DocumentClassifier, and ActivityConverter implementations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/STREAMS-276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Blackmon updated STREAMS-276: ----------------------------------- Description: For each provider where the proposed re-factoring improvement is feasible, create sub-tasks to perform the following: 1) Add a DocumentClassifier for each provider-specific type combination the provider expects to receive from all upstream end-points. 2) Add a test demonstrating one and only one of these Classifiers returns true across a set of example origin documents. 3) Add an ActivityConverter for each objectType/Verb combination the provider expects to emit. requiredClass should be one of String.class, ObjectNode.class, or a POJO which extends Serializable. 4) Add tests demonstrating that ActivityConverterProcessor is able to convert the set of example origin documents into activities with correct objectType/verb. 5) Add a StreamsDateTimeFormat for each non-RFC3339 date string the provider expects to receive. 6) Add a test demonstrating that StreamsJacksonMapper is able to convert matching date strings to DateTimes. 7) Mark legacy TypeConverters as Deprecated For any provider where the proposed re-factoring improvement is not feasible, document why in the module README and/or create issues for whatever refactoring would be necessary to make that provider compatible with ActivityConverterProcessor. was: For each provider where the proposed re-factoring improvement is feasible, create sub-tasks to perform the following: 1) Add a DocumentClassifier for each provider-specific type combination the provider expects to receive from all upstream end-points. 2) Add a test demonstrating one and only one of these Classifiers returns true across a set of example origin documents. 3) Add an ActivityConverter for each objectType/Verb combination the provider expects to emit. requiredClass should be one of String.class, ObjectNode.class, or a POJO which extends Serializable. 4) Add tests demonstrating that ActivityConverterProcessor is able to convert the set of example origin documents into activities with correct objectType/verb. 5) Mark legacy TypeConverters as Deprecated For any provider where the proposed re-factoring improvement is not feasible, document why in the module README and/or create issues for whatever refactoring would be necessary to make that provider compatible with ActivityConverterProcessor. > Upgrade providers to supply StreamsDateTimeFormat, DocumentClassifier, and ActivityConverter implementations > ------------------------------------------------------------------------------------------------------------ > > Key: STREAMS-276 > URL: https://issues.apache.org/jira/browse/STREAMS-276 > Project: Streams > Issue Type: Improvement > Reporter: Steve Blackmon > > For each provider where the proposed re-factoring improvement is feasible, create sub-tasks to perform the following: > 1) Add a DocumentClassifier for each provider-specific type combination the provider expects to receive from all upstream end-points. > 2) Add a test demonstrating one and only one of these Classifiers returns true across a set of example origin documents. > 3) Add an ActivityConverter for each objectType/Verb combination the provider expects to emit. requiredClass should be one of String.class, ObjectNode.class, or a POJO which extends Serializable. > 4) Add tests demonstrating that ActivityConverterProcessor is able to convert the set of example origin documents into activities with correct objectType/verb. > 5) Add a StreamsDateTimeFormat for each non-RFC3339 date string the provider expects to receive. > 6) Add a test demonstrating that StreamsJacksonMapper is able to convert matching date strings to DateTimes. > 7) Mark legacy TypeConverters as Deprecated > For any provider where the proposed re-factoring improvement is not feasible, document why in the module README and/or create issues for whatever refactoring would be necessary to make that provider compatible with ActivityConverterProcessor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)