Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@streams.incubator.apache.org
From: mfranklin <git@git.apache.org>
To: dev@streams.incubator.apache.org
Reply-To: dev@streams.incubator.apache.org
References: <git-pr-167-incubator-streams@git.apache.org>
In-Reply-To: <git-pr-167-incubator-streams@git.apache.org>
Subject: [GitHub] incubator-streams pull request: STREAMS-243 | Updated
 S3Configurat...
Content-Type: text/plain
Message-Id: <20150224073135.4117BE03E8@git1-us-west.apache.org>
Date: Tue, 24 Feb 2015 07:31:35 +0000 (UTC)

Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/167#discussion_r25233223
  
    --- Diff: streams-contrib/streams-amazon-aws/streams-persist-s3/src/main/java/org/apache/streams/s3/S3Configurator.java ---
    @@ -64,15 +64,15 @@ public static S3WriterConfiguration detectWriterConfiguration(Config s3) {
     
             try {
                 s3Configuration = mapper.readValue(s3.root().render(ConfigRenderOptions.concise()), S3WriterConfiguration.class);
    +
    +            if(!s3Configuration.getWriterPath().endsWith("/")) {
    +                s3Configuration.setWriterPath(s3Configuration.getWriterPath() + "/");
    +            }
             } catch (Exception e) {
                 e.printStackTrace();
    --- End diff --
    
    since you are in here, remove e.printStackTrace().  If the exception needs to be output to the console, it needs to be output to the logs.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---