streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (STREAMS-288) StreamsJacksonModule should not scan for DateTimeFormats by default
Date Tue, 17 Feb 2015 20:06:11 GMT


ASF GitHub Bot commented on STREAMS-288:

Github user smashew commented on the pull request:
    I mean, technically, this allevates the issue. 
    A better approach would be 
    private final static Class<? extends StreamsDateFormat> dtClazzes;
    static {
     // Load dtClazzes
    // Scanner slow stuff here... Put a"") message to apologize to the user how
long this will take and that you are sorry for the inconvenience. 

> StreamsJacksonModule should not scan for DateTimeFormats by default
> -------------------------------------------------------------------
>                 Key: STREAMS-288
>                 URL:
>             Project: Streams
>          Issue Type: Bug
>            Reporter: Robert Douglas
> The StreamsJacksonModule's constructor is called all over the codebase and by default,
it uses Reflections to scan the classpath for valid DateTimeFormats.
> This is problematic because it will happen multiple times during a Stream's runtime,
considerably slowing down the execution.
> Instead, we should default to NOT scanning the classpath, but provide a constructor where
we can pass in a flag dictating whether or not we want to scan.

This message was sent by Atlassian JIRA

View raw message