streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-288) StreamsJacksonModule should not scan for DateTimeFormats by default
Date Tue, 17 Feb 2015 19:57:12 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324772#comment-14324772
] 

ASF GitHub Bot commented on STREAMS-288:
----------------------------------------

GitHub user robdouglas opened a pull request:

    https://github.com/apache/incubator-streams/pull/187

    STREAMS-288 | Removing default behavior where we scan the class path loo...

    ...king for any valid DateTimeFormats. Instead, this functionality has been moved to a
secondary constructor where we can pass in a flag to specify whether or not we want this behavior.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robdouglas/incubator-streams STREAMS-288

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-streams/pull/187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #187
    
----
commit 7329bc25cb7562c3f67e846eb87a17b8c8298e17
Author: Robert Douglas <rdouglas@w2ogroup.com>
Date:   2015-02-17T19:54:26Z

    STREAMS-288 | Removing default behavior where we scan the class path looking for any valid
DateTimeFormats. Instead, this functionality has been moved to a secondary constructor where
we can pass in a flag to specify whether or not we want this behavior.

commit 4eb9a07cbf518fd97c4b477463c3d5f8f3eb1fe5
Author: Robert Douglas <rdouglas@w2ogroup.com>
Date:   2015-02-17T19:56:18Z

    STREAMS-288 | Deserializer initialization changes

----


> StreamsJacksonModule should not scan for DateTimeFormats by default
> -------------------------------------------------------------------
>
>                 Key: STREAMS-288
>                 URL: https://issues.apache.org/jira/browse/STREAMS-288
>             Project: Streams
>          Issue Type: Bug
>            Reporter: Robert Douglas
>
> The StreamsJacksonModule's constructor is called all over the codebase and by default,
it uses Reflections to scan the classpath for valid DateTimeFormats.
> This is problematic because it will happen multiple times during a Stream's runtime,
considerably slowing down the execution.
> Instead, we should default to NOT scanning the classpath, but provide a constructor where
we can pass in a flag dictating whether or not we want to scan.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message