streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-243) S3 Persist Writer does not flush or shutdown on stream shutdown
Date Tue, 24 Feb 2015 07:32:12 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334533#comment-14334533
] 

ASF GitHub Bot commented on STREAMS-243:
----------------------------------------

Github user mfranklin commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/167#discussion_r25233223
  
    --- Diff: streams-contrib/streams-amazon-aws/streams-persist-s3/src/main/java/org/apache/streams/s3/S3Configurator.java
---
    @@ -64,15 +64,15 @@ public static S3WriterConfiguration detectWriterConfiguration(Config
s3) {
     
             try {
                 s3Configuration = mapper.readValue(s3.root().render(ConfigRenderOptions.concise()),
S3WriterConfiguration.class);
    +
    +            if(!s3Configuration.getWriterPath().endsWith("/")) {
    +                s3Configuration.setWriterPath(s3Configuration.getWriterPath() + "/");
    +            }
             } catch (Exception e) {
                 e.printStackTrace();
    --- End diff --
    
    since you are in here, remove e.printStackTrace().  If the exception needs to be output
to the console, it needs to be output to the logs.  


> S3 Persist Writer does not flush or shutdown on stream shutdown
> ---------------------------------------------------------------
>
>                 Key: STREAMS-243
>                 URL: https://issues.apache.org/jira/browse/STREAMS-243
>             Project: Streams
>          Issue Type: Bug
>            Reporter: Steve Blackmon
>
> S3 Persist Writer does not seem to flush or shutdown on stream shutdown, which has the
side-effect of not allowing the stream process to close.
> When cleanUp() is called, the writer should flush and terminate gracefully.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message