streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfranklin <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: STREAMS-288 | Removing default beh...
Date Tue, 17 Feb 2015 20:30:40 GMT
Github user mfranklin commented on the pull request:

    https://github.com/apache/incubator-streams/pull/187#issuecomment-74746842
  
    I suggest making the constructor protected.  That way external callers get an instance
of the singleton via the getInstance() method and you are not scanning the classpath a ton
of times.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message