streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robdouglas <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Streams 283
Date Tue, 17 Feb 2015 17:11:58 GMT
Github user robdouglas commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/183#discussion_r24832457
  
    --- Diff: streams-monitoring/src/main/java/org/apache/streams/monitoring/persist/impl/LogstashUdpMessagePersister.java
---
    @@ -0,0 +1,104 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.streams.monitoring.persist.impl;
    +
    +import org.apache.streams.monitoring.persist.MessagePersister;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.net.DatagramPacket;
    +import java.net.DatagramSocket;
    +import java.net.InetAddress;
    +import java.net.InetSocketAddress;
    +import java.net.SocketAddress;
    +import java.net.SocketException;
    +import java.net.URI;
    +import java.net.URISyntaxException;
    +import java.nio.ByteBuffer;
    +import java.util.List;
    +import java.util.concurrent.Executors;
    +
    +public class LogstashUdpMessagePersister implements MessagePersister {
    +
    +    private final static Logger LOGGER = LoggerFactory.getLogger(LogstashUdpMessagePersister.class);
    +    private String broadcastURI;
    +    URI uri;
    +
    +    public LogstashUdpMessagePersister(String broadcastURI) {
    +        this.broadcastURI = broadcastURI;
    +        setup();
    +    }
    +
    +    public void setup() {
    +
    +        try {
    +            uri = new URI(broadcastURI);
    +        } catch (URISyntaxException e) {
    +            e.printStackTrace();
    --- End diff --
    
    Can we log this entire exception, instead of printing the stack trace?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message