streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robdouglas <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Streams 279
Date Tue, 17 Feb 2015 17:09:12 GMT
Github user robdouglas commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/184#discussion_r24832205
  
    --- Diff: streams-contrib/streams-provider-youtube/src/main/java/com/youtube/serializer/YoutubeActivityUtil.java
---
    @@ -67,6 +70,40 @@ public static void updateActivity(Video video, Activity activity, String
channel
             addYoutubeExtensions(activity, video);
         }
     
    +
    +    /**
    +     * Given a {@link com.google.api.services.youtube.model.Channel} object and an
    +     * {@link org.apache.streams.pojo.json.Activity} object, fill out the appropriate
details
    +     *
    +     * @param channel
    +     * @param activity
    +     * @throws org.apache.streams.exceptions.ActivitySerializerException
    +     */
    +    public static void updateActivity(Channel channel, Activity activity, String channelId)
throws ActivitySerializerException {
    +        try {
    +            activity.setProvider(getProvider());
    +            Actor actor = new Actor();
    --- End diff --
    
    Could you move this actor creation to a separate method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message