Return-Path: X-Original-To: apmail-streams-dev-archive@minotaur.apache.org Delivered-To: apmail-streams-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0C17010616 for ; Tue, 6 Jan 2015 15:59:55 +0000 (UTC) Received: (qmail 58714 invoked by uid 500); 6 Jan 2015 15:59:56 -0000 Delivered-To: apmail-streams-dev-archive@streams.apache.org Received: (qmail 58669 invoked by uid 500); 6 Jan 2015 15:59:56 -0000 Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@streams.incubator.apache.org Delivered-To: mailing list dev@streams.incubator.apache.org Received: (qmail 58544 invoked by uid 99); 6 Jan 2015 15:59:56 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jan 2015 15:59:56 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 06 Jan 2015 15:59:55 +0000 Received: (qmail 57985 invoked by uid 99); 6 Jan 2015 15:59:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jan 2015 15:59:34 +0000 Date: Tue, 6 Jan 2015 15:59:34 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@streams.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (STREAMS-260) FacebookPageFeedDataCollector should handle backoff strategy correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/STREAMS-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266303#comment-14266303 ] ASF GitHub Bot commented on STREAMS-260: ---------------------------------------- Github user rbnks commented on the pull request: https://github.com/apache/incubator-streams/pull/169#issuecomment-68884339 +1 > FacebookPageFeedDataCollector should handle backoff strategy correctly > ---------------------------------------------------------------------- > > Key: STREAMS-260 > URL: https://issues.apache.org/jira/browse/STREAMS-260 > Project: Streams > Issue Type: Bug > Reporter: Robert Douglas > > As a Stream user, I should be able to correctly respond to Facebook rate limit exceptions. Currently, any error from the Facebook Graph API results in a call to the exponential backoff strategy. This is fine if we are actually getting requests throttled/rate limited, but can result in very slow Stream completion if the error is related to something else (like a bad Page ID). > We need to ensure that we only use the backoff strategy when we are being rate limited. > *Acceptance Criteria:* > - Determine which error codes represent potential rate limiting/throttling exceptions > - Only call the backoff when our requests are being throttled. -- This message was sent by Atlassian JIRA (v6.3.4#6332)