streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-260) FacebookPageFeedDataCollector should handle backoff strategy correctly
Date Fri, 02 Jan 2015 21:08:34 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263235#comment-14263235
] 

ASF GitHub Bot commented on STREAMS-260:
----------------------------------------

GitHub user robdouglas opened a pull request:

    https://github.com/apache/incubator-streams/pull/169

    STREAMS-260 | Only calling the back off strategy in the even that we get...

    ... a rate limit or throttling error/exception from the Facebook Graph API

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robdouglas/incubator-streams STREAMS-260

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-streams/pull/169.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #169
    
----
commit 94c7bef228113c5ef3fa9313e13f011b1bceb70e
Author: Robert Douglas <rdouglas@w2ogroup.com>
Date:   2015-01-02T21:06:37Z

    STREAMS-260 | Only calling the back off strategy in the even that we get a rate limit
or throttling error/exception from the Facebook Graph API

----


> FacebookPageFeedDataCollector should handle backoff strategy correctly
> ----------------------------------------------------------------------
>
>                 Key: STREAMS-260
>                 URL: https://issues.apache.org/jira/browse/STREAMS-260
>             Project: Streams
>          Issue Type: Bug
>            Reporter: Robert Douglas
>
> As a Stream user, I should be able to correctly respond to Facebook rate limit exceptions.
Currently, any error from the Facebook Graph API results in a call to the exponential backoff
strategy. This is fine if we are actually getting requests throttled/rate limited, but can
result in very slow Stream completion if the error is related to something else (like a bad
Page ID).
> We need to ensure that we only use the backoff strategy when we are being rate limited.
> *Acceptance Criteria:*
> - Determine which error codes represent potential rate limiting/throttling exceptions
> - Only call the backoff when our requests are being throttled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message