Return-Path: X-Original-To: apmail-streams-dev-archive@minotaur.apache.org Delivered-To: apmail-streams-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D119EC58F for ; Fri, 5 Dec 2014 23:26:36 +0000 (UTC) Received: (qmail 95148 invoked by uid 500); 5 Dec 2014 23:26:36 -0000 Delivered-To: apmail-streams-dev-archive@streams.apache.org Received: (qmail 95105 invoked by uid 500); 5 Dec 2014 23:26:36 -0000 Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@streams.incubator.apache.org Delivered-To: mailing list dev@streams.incubator.apache.org Received: (qmail 95094 invoked by uid 99); 5 Dec 2014 23:26:36 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Dec 2014 23:26:36 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 05 Dec 2014 23:26:14 +0000 Received: (qmail 93543 invoked by uid 99); 5 Dec 2014 23:26:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Dec 2014 23:26:12 +0000 Date: Fri, 5 Dec 2014 23:26:12 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@streams.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (STREAMS-239) streams-processor-urls test failure (regression) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/STREAMS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236293#comment-14236293 ] ASF GitHub Bot commented on STREAMS-239: ---------------------------------------- Github user steveblackmon commented on a diff in the pull request: https://github.com/apache/incubator-streams/pull/156#discussion_r21407907 --- Diff: streams-contrib/streams-processor-urls/src/test/java/org/apache/streams/urls/TestLinkUnwinderProcessor.java --- @@ -39,12 +40,28 @@ private static String activityString; @Test + public void testLinkUnwinderBadDomain() { + LinkResolver resolver = new LinkResolver("http://nope@#$%"); + resolver.run(); + LinkDetails details = resolver.getLinkDetails(); + assertEquals("Should be 404", LinkDetails.LinkStatus.MALFORMED_URL, details.getLinkStatus()); --- End diff -- Well it's not really a server error, because the url isn't actionable, but I'm not sure 404 Not Found is not really appropriate either. Asking myself WWGD... https://developers.google.com/gdata/docs/2.0/reference?csw=1#HTTPStatusCodes I'll change this condition to return 400 - Bad Request. > streams-processor-urls test failure (regression) > ------------------------------------------------ > > Key: STREAMS-239 > URL: https://issues.apache.org/jira/browse/STREAMS-239 > Project: Streams > Issue Type: Bug > Reporter: Steve Blackmon > Priority: Critical > > a new streams-processor-urls test failure appeared 12/01/2014. > https://builds.apache.org/job/Streams%20Trunk/105/org.apache.streams$streams-processor-urls/testReport/junit/org.apache.streams.urls/TestLinkUnwinderProcessor/testActivityLinkUnwinderProcessorUnwindable/ > Diagnose root cause and fix or ignore test as appropriate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)