streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (STREAMS-243) S3 Persist Writer does not flush or shutdown on stream shutdown
Date Tue, 09 Dec 2014 00:18:13 GMT


ASF GitHub Bot commented on STREAMS-243:

GitHub user robdouglas opened a pull request:

    STREAMS-243 | S3PersistWriter No Longer Dies Silently

    Added more detailed logging in the S3PersistWriter's prepare method so that we can see
any issues as they arise. Added tests to the S3PersistWriter to assert that appropriate exceptions
are thrown when expected. Updated code in LocalStreamBuilder to ensure that the 'isRunning'
calculation is more accurate.

You can merge this pull request into a Git repository by running:

    $ git pull STREAMS-243

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #162
commit 6aba90b90d55cc19c1f70d0839e9311d5e8356ad
Author: Robert Douglas <>
Date:   2014-12-08T23:55:16Z

    STREAMS-243 | Added better exception handling for the S3PersistWriter and made the shutdown
conditions in the LocalStreamBuilder more robust

commit 8439ff66427642c5d1d49e0cba222e1bf0e80f93
Author: Robert Douglas <>
Date:   2014-12-08T23:58:23Z

    Merge branch 'upstream-apache-master' into STREAMS-243

commit 63438d1c6372120fa4a728c28c821ebe3e555c6b
Author: Robert Douglas <>
Date:   2014-12-09T00:15:51Z

    STREAMS-243 | Removed unnecessary precondition failure and replaced with code that rectifies
that failure


> S3 Persist Writer does not flush or shutdown on stream shutdown
> ---------------------------------------------------------------
>                 Key: STREAMS-243
>                 URL:
>             Project: Streams
>          Issue Type: Bug
>            Reporter: Steve Blackmon
> S3 Persist Writer does not seem to flush or shutdown on stream shutdown, which has the
side-effect of not allowing the stream process to close.
> When cleanUp() is called, the writer should flush and terminate gracefully.

This message was sent by Atlassian JIRA

View raw message