[ https://issues.apache.org/jira/browse/STREAMS-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236293#comment-14236293
]
ASF GitHub Bot commented on STREAMS-239:
----------------------------------------
Github user steveblackmon commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/156#discussion_r21407907
--- Diff: streams-contrib/streams-processor-urls/src/test/java/org/apache/streams/urls/TestLinkUnwinderProcessor.java
---
@@ -39,12 +40,28 @@
private static String activityString;
@Test
+ public void testLinkUnwinderBadDomain() {
+ LinkResolver resolver = new LinkResolver("http://nope@#$%");
+ resolver.run();
+ LinkDetails details = resolver.getLinkDetails();
+ assertEquals("Should be 404", LinkDetails.LinkStatus.MALFORMED_URL, details.getLinkStatus());
--- End diff --
Well it's not really a server error, because the url isn't actionable, but I'm not sure
404 Not Found is not really appropriate either.
Asking myself WWGD...
https://developers.google.com/gdata/docs/2.0/reference?csw=1#HTTPStatusCodes
I'll change this condition to return 400 - Bad Request.
> streams-processor-urls test failure (regression)
> ------------------------------------------------
>
> Key: STREAMS-239
> URL: https://issues.apache.org/jira/browse/STREAMS-239
> Project: Streams
> Issue Type: Bug
> Reporter: Steve Blackmon
> Priority: Critical
>
> a new streams-processor-urls test failure appeared 12/01/2014.
> https://builds.apache.org/job/Streams%20Trunk/105/org.apache.streams$streams-processor-urls/testReport/junit/org.apache.streams.urls/TestLinkUnwinderProcessor/testActivityLinkUnwinderProcessorUnwindable/
> Diagnose root cause and fix or ignore test as appropriate.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
|