streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From steveblackmon <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Streams 242
Date Fri, 05 Dec 2014 23:37:40 GMT
Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/155#discussion_r21408403
  
    --- Diff: streams-contrib/streams-provider-datasift/src/test/java17/org/apache/streams/datasift/serializer/DatasiftEventClassifierTest.java
---
    @@ -50,7 +57,10 @@ public void testTwitterDetection() throws Exception {
     
         @Test
         public void testInstagramDetection() throws Exception {
    -        Scanner scanner = new Scanner(DatasiftActivitySerializerTest.class.getResourceAsStream("/instagram_datasift_json.txt"));
    +
    --- End diff --
    
    agree, i'll factor it out to a new utility class in streams-runtime-local:test-jar where
any module that needs a solid scanner can access it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message