streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robdouglas <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: resolves STREAMS-239
Date Fri, 05 Dec 2014 22:03:28 GMT
Github user robdouglas commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/156#discussion_r21403622
  
    --- Diff: streams-contrib/streams-processor-urls/src/test/java/org/apache/streams/urls/TestLinkUnwinderProcessor.java
---
    @@ -39,12 +40,28 @@
         private static String activityString;
     
         @Test
    +    public void testLinkUnwinderBadDomain() {
    +        LinkResolver resolver = new LinkResolver("http://nope@#$%");
    +        resolver.run();
    +        LinkDetails details = resolver.getLinkDetails();
    +        assertEquals("Should be 404", LinkDetails.LinkStatus.MALFORMED_URL, details.getLinkStatus());
    --- End diff --
    
    Shouldn't this message be changed to "Should be 500"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message