streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From steveblackmon <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: rolling back https://github.com/ap...
Date Tue, 02 Dec 2014 19:11:17 GMT
Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/152#discussion_r21182611
  
    --- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/builders/LocalStreamBuilder.java
---
    @@ -316,6 +315,7 @@ protected void setupComponentTasks(Map<String, List<StreamsTask>>
streamsTasks)
                     this.futures.put(task, this.executor.submit(task));
                     compTasks.add(task);
                     if( comp.isOperationCountable() ) {
    +                    this.monitor.submit(broadcastMonitor);
    --- End diff --
    
    this PR reverts to the version that existed before merging https://github.com/apache/incubator-streams/pull/140
    
    we need to re-open STREAMS-230, dive a bit deeper into implications of the issue there,
and take special care that the next attempt to address the issue does not cause any test failures,
regular or sporadic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message