streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robdouglas <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: rolling back https://github.com/ap...
Date Tue, 02 Dec 2014 19:06:11 GMT
Github user robdouglas commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/152#discussion_r21182204
  
    --- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/builders/LocalStreamBuilder.java
---
    @@ -316,6 +315,7 @@ protected void setupComponentTasks(Map<String, List<StreamsTask>>
streamsTasks)
                     this.futures.put(task, this.executor.submit(task));
                     compTasks.add(task);
                     if( comp.isOperationCountable() ) {
    +                    this.monitor.submit(broadcastMonitor);
    --- End diff --
    
    Does this submit the broadcastMonitor regardless of the timeout that is set in the config?
It'd be nice to have a way to not include it if the user wants to


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message