[ https://issues.apache.org/jira/browse/STREAMS-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215400#comment-14215400
]
ASF GitHub Bot commented on STREAMS-216:
----------------------------------------
Github user steveblackmon commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/130#discussion_r20474623
--- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/builders/LocalStreamBuilder.java
---
@@ -119,7 +129,7 @@ public void run() {
@Override
public StreamBuilder newPerpetualStream(String id, StreamsProvider provider) {
validateId(id);
- this.providers.put(id, new StreamComponent(id, provider, true));
+ this.providers.put(id, new StreamComponent(id, provider, true, streamConfig));
--- End diff --
However, I think its best not to expand the scope of this story.
So +1, and I'll open a new story to consolidate all usage of stream-wide configuration
options into StreamsConfiguration
> Update JMX beans so that we have identifying information
> --------------------------------------------------------
>
> Key: STREAMS-216
> URL: https://issues.apache.org/jira/browse/STREAMS-216
> Project: Streams
> Issue Type: Sub-task
> Reporter: Robert Douglas
>
> We need to have all of our JMX beans created with identifying information so we know
which stream it is associated with. LocalStreamBuilder needs to take in a String identifier
which will then be used. This is essential in order for us to make sense of the messages that
we receive.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
|