streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robdouglas <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Shutdown refinement
Date Thu, 20 Nov 2014 23:52:25 GMT
Github user robdouglas commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/139#discussion_r20687681
  
    --- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/builders/LocalStreamBuilder.java
---
    @@ -377,6 +379,20 @@ public void stop() {
             stopInternal(false);
         }
     
    +    /**
    +     * Attempts to shut down the stream and let all data in flight finish processing.
 When shutdown(long) is called, it
    +     * immediately stops all {@link org.apache.streams.core.StreamsProvider}s and will
attempt to let all {@link org.apache.streams.core.StreamsProcessor}s
    +     * and all {@link org.apache.streams.core.StreamsPersistWriter}s finish processing.
    +     * @param waitInMs
    +     */
    +    public void shutdown(Long waitInMs) {
    --- End diff --
    
    Are these methods supposed to be fleshed out or are they acting as placeholders?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message