streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rbnks <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Gplus fix
Date Tue, 18 Nov 2014 14:53:25 GMT
Github user rbnks commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/133#discussion_r20509428
  
    --- Diff: streams-contrib/streams-provider-google/google-gplus/src/main/jsonschema/com/google/gplus/GPlusConfiguration.json
---
    @@ -54,21 +54,18 @@
                 "dynamic": "true",
                 "javaType" : "org.apache.streams.google.gplus.GPlusOAuthConfiguration",
                 "javaInterfaces": ["java.io.Serializable"],
    +            "description": "DEPRICATED",
                 "properties": {
                     "appName": {
                         "type": "string"
                     },
    -                "consumerKey": {
    -                    "type": "string"
    -                },
    -                "consumerSecret": {
    -                    "type": "string"
    -                },
    -                "accessToken": {
    -                    "type": "string"
    +                "pathToP12KeyFile": {
    +                    "type": "string",
    +                    "description": "Absolute Path to key file"
                     },
    -                "accessTokenSecret": {
    -                    "type": "string"
    +                "serviceAccountEmailAddress": {
    +                    "type": "string",
    +                    "description": "Service Account email address for your app"
    --- End diff --
    
    The documentation is pretty poor for the credentials.  I would not rule it out as a possibility,
but I was not able to make it work.  It took me a day to realize that the parameter that when
it access for the 'account service id', it is actually asking for the 'account service email'.
 I'm not ruling it out as impossible, but at the moment this seems to be the only working
way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message