streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From steveblackmon <>
Subject [GitHub] incubator-streams pull request: STREAMS-216 | Identifying Stream i...
Date Mon, 17 Nov 2014 23:30:40 GMT
Github user steveblackmon commented on a diff in the pull request:
    --- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/builders/
    @@ -119,7 +129,7 @@ public void run() {
         public StreamBuilder newPerpetualStream(String id, StreamsProvider provider) {
    -        this.providers.put(id, new StreamComponent(id, provider, true));
    +        this.providers.put(id, new StreamComponent(id, provider, true, streamConfig));
    --- End diff --
    However, I think its best not to expand the scope of this story.  
    So +1, and I'll open a new story to consolidate all usage of stream-wide configuration
options into StreamsConfiguration

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message