streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From steveblackmon <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Streams 211
Date Wed, 12 Nov 2014 05:30:55 GMT
Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/125#discussion_r20202083
  
    --- Diff: pom.xml ---
    @@ -93,6 +93,8 @@
             <maven.enforcer.plugin.version>1.3.1</maven.enforcer.plugin.version>
             <mockito.version>1.9.5</mockito.version>
             <powermock.version>1.5.6</powermock.version>
    +        <httpcomponents.core.version>4.3.3</httpcomponents.core.version>
    +        <httpcomponents.client.version>4.3.5</httpcomponents.client.version>
    --- End diff --
    
    Specifying these versions in the room pom is probably ok - although these specific libraries
have a knack for causing problems when then forced on modules build against earlier versions.
 but please remove any explicit or sub-module-property version declarations.  Believe streams-components/streams-http
is the other place we depend on it directly


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message