streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From steveblackmon <>
Subject [GitHub] incubator-streams pull request: move type conversion and date form...
Date Tue, 11 Nov 2014 18:52:35 GMT
Github user steveblackmon commented on a diff in the pull request:
    --- Diff: streams-contrib/streams-provider-datasift/src/test/java17/org/apache/streams/datasift/serializer/
    @@ -0,0 +1,76 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.streams.datasift.serializer;
    +import com.fasterxml.jackson.databind.JsonNode;
    +import com.fasterxml.jackson.databind.ObjectMapper;
    +import org.apache.streams.datasift.Datasift;
    +import org.apache.streams.datasift.instagram.Instagram;
    +import org.apache.streams.datasift.twitter.Twitter;
    +import org.apache.streams.datasift.util.StreamsDatasiftMapper;
    +import org.apache.streams.jackson.StreamsJacksonMapper;
    +import org.apache.streams.twitter.pojo.Delete;
    +import org.apache.streams.twitter.pojo.Retweet;
    +import org.apache.streams.twitter.pojo.Tweet;
    +import org.apache.streams.twitter.pojo.User;
    +import org.apache.streams.twitter.provider.TwitterEventClassifier;
    +import org.apache.streams.twitter.serializer.TwitterJsonDeleteActivitySerializer;
    +import org.apache.streams.twitter.serializer.TwitterJsonRetweetActivitySerializer;
    +import org.apache.streams.twitter.serializer.TwitterJsonTweetActivitySerializer;
    +import org.apache.streams.twitter.serializer.TwitterJsonUserActivitySerializer;
    +import org.junit.Assert;
    +import org.junit.Test;
    +import java.util.Scanner;
    + * Created by sblackmon on 12/13/13.
    + */
    +public class DatasiftEventClassifierTest {
    --- End diff --
    InteractionActivitySerializer isn't critical, it's a fallback for documents whose channel
is unresolvable.  But I agree it should be tested and will add a test that forces it to run
on documents from multiple channels.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message