streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robdouglas <...@git.apache.org>
Subject [GitHub] incubator-streams pull request: Gplus
Date Fri, 07 Nov 2014 15:50:46 GMT
Github user robdouglas commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/122#discussion_r20017521
  
    --- Diff: streams-contrib/streams-provider-google/google-gplus/src/main/java/com/google/gplus/provider/GPlusUserDataCollector.java
---
    @@ -0,0 +1,101 @@
    +package com.google.gplus.provider;
    --- End diff --
    
    I see a fair amount of code/variables shared between the GPlusUserDataCollector and the
GPlusUserActivityCollector. Would it make more sense to abstract out these commonalities (like
the object mapper/gPlus Object/BackOffStrategy and the error code logic) to a common super
class that both of these classes could extend? No sense in duplicating code when we don't
have to


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message