Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@streams.incubator.apache.org
From: rbnks <git@git.apache.org>
To: dev@streams.incubator.apache.org
Reply-To: dev@streams.incubator.apache.org
Message-ID: <git-pr-108-incubator-streams@git.apache.org>
Subject: [GitHub] incubator-streams pull request: STREAMS-198 | Depricate
 DatumCount...
Content-Type: text/plain
Date: Mon, 20 Oct 2014 21:16:57 +0000 (UTC)

GitHub user rbnks opened a pull request:

    https://github.com/apache/incubator-streams/pull/108

    STREAMS-198 | Depricate DatumCountable

    Related to pull request #107, should be reviewed after it is merged.
    
    Depricated DatumCountable and DatumStatusCounter.  They are both incorrectly located in streams-core, as they are runtime specific classes.  They should be scheduled to be deleted from the repo.  This pull request only adds @Depreicated tags to classes and methods.  It also turns off the printed monitoring to the console by default, but allows it to still be used if desired.
    
    The printing uses extras threads to monitor things that could be monitored through JMX instead.  Also the implementation of the countables does not allow counts across threads.  It is a good implementation for single thread counts, but the new implementation should make this obsolete and also will be correctly located in the streams-local package.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rbnks/incubator-streams STREAMS-198

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-streams/pull/108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #108
    
----
commit 2a635dfe87974076075494ff7d4833a3007c0af3
Author: Ryan Ebanks <rbnks@users.noreply.github.com>
Date:   2014-10-17T19:06:46Z

    Merge pull request #7 from apache/master
    
    apache master merge 2014/10/17

commit c030d4393ab84fbd1cf484bf8ea06a7902a26964
Author: Ryan Ebanks <ryanebanks@gmail.com>
Date:   2014-10-17T22:13:51Z

    Created MXBean for counts and depricated DatumStatusCounter and DatumStatusCountable in core

commit 3d5478393acce626ca7482fbd27e2b75e74d8799
Author: Ryan Ebanks <ryanebanks@gmail.com>
Date:   2014-10-17T22:36:00Z

    Depricated printable monitoring solution, and turned it off by default

commit 6916a1b78318f7dec9d73121e25e1f6b545c9a78
Author: Ryan Ebanks <ryanebanks@gmail.com>
Date:   2014-10-17T22:53:34Z

    Added processing time

commit 393c2e79b2534bb7f8ba344b6418488c84338c87
Author: Ryan Ebanks <ryanebanks@gmail.com>
Date:   2014-10-17T23:03:04Z

    Added java doc

commit 6ecf46d2d371ff1ee27d6f3da189388892148fcb
Author: Ryan Ebanks <rbnks@users.noreply.github.com>
Date:   2014-10-20T17:50:25Z

    Merge pull request #8 from apache/master
    
    Merge Apache Master 2014/10/20

commit d305371364b2340f26a66618aa614ca6f3ce6ee4
Author: Ryan Ebanks <ryanebanks@gmail.com>
Date:   2014-10-20T17:53:31Z

    Merge branch 'master' into datumcountable

commit 8945fa94ec9893a0e09471bed9853695b08409e1
Author: Ryan Ebanks <ryanebanks@gmail.com>
Date:   2014-10-20T19:19:26Z

    Added more @Deprecated annotations

commit bfffc5f7261b9117dd33bab7259e95e6de1f5e26
Author: Ryan Ebanks <ryanebanks@gmail.com>
Date:   2014-10-20T20:32:13Z

    Changed NAME_TEMPLATE

commit f40ce9b0db7bc082ce98722529f69881d85f3c8f
Author: Ryan Ebanks <ryanebanks@gmail.com>
Date:   2014-10-20T21:00:26Z

    STREAMS-197 | Avg time now will count for providers and does not include errors in calculations

commit 4f2e3cf2ebd7c8251eb70f5f81eb4ebb90fd26f5
Author: Ryan Ebanks <ryanebanks@gmail.com>
Date:   2014-10-20T21:10:39Z

    STREAMS-198 | Merged STREAMS-197 pull request

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---