Return-Path: 
 <dev-return-1902-apmail-streams-dev-archive=streams.apache.org@streams.incubator.apache.org>
X-Original-To: apmail-streams-dev-archive@minotaur.apache.org
Delivered-To: apmail-streams-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id CC60417DB7
	for <apmail-streams-dev-archive@minotaur.apache.org>;
 Tue,  7 Oct 2014 14:41:55 +0000 (UTC)
Received: (qmail 82400 invoked by uid 500); 7 Oct 2014 14:41:55 -0000
Delivered-To: apmail-streams-dev-archive@streams.apache.org
Received: (qmail 82357 invoked by uid 500); 7 Oct 2014 14:41:55 -0000
Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@streams.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@streams.incubator.apache.org>
List-Post: <mailto:dev@streams.incubator.apache.org>
List-Id: <dev.streams.incubator.apache.org>
Reply-To: dev@streams.incubator.apache.org
Delivered-To: mailing list dev@streams.incubator.apache.org
Received: (qmail 82345 invoked by uid 99); 7 Oct 2014 14:41:55 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Oct 2014 14:41:55 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Tue, 07 Oct 2014 14:41:54 +0000
Received: (qmail 82283 invoked by uid 99); 7 Oct 2014 14:41:34 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Oct 2014 14:41:34 +0000
Date: Tue, 7 Oct 2014 14:41:34 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@streams.incubator.apache.org
Message-ID: <JIRA.12741883.1410893245000.208196.1412692894498@Atlassian.JIRA>
In-Reply-To: <JIRA.12741883.1410893245000@Atlassian.JIRA>
References: <JIRA.12741883.1410893245000@Atlassian.JIRA>
 <JIRA.12741883.1410893245103@arcas>
Subject: [jira] [Commented] (STREAMS-176) TwitterTimelineProvider and Task
 should allow for overriding certain methods
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/STREAMS-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161950#comment-14161950 ] 

ASF GitHub Bot commented on STREAMS-176:
----------------------------------------

Github user robdouglas commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/86#discussion_r18523292
  
    --- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java ---
    @@ -116,11 +115,11 @@ public void startStream() {
             executor.shutdown();
         }
     
    -    protected boolean shouldContinuePulling(List<Status> statuses) {
    +    public boolean shouldContinuePulling(List<Status> statuses) {
    --- End diff --
    
    In the event that an individual needs to override the TwitterTimelineProvider and use those overridden methods in an overridden version of TwitterTimelineProviderTask, they would need to be marked public in order to be visible.


> TwitterTimelineProvider and Task should allow for overriding certain methods
> ----------------------------------------------------------------------------
>
>                 Key: STREAMS-176
>                 URL: https://issues.apache.org/jira/browse/STREAMS-176
>             Project: Streams
>          Issue Type: Task
>            Reporter: Robert Douglas
>
> There are certain methods where it could be beneficial for a downstream developer to override. Functions like submitTimelineThreads, getTwitterClient, and addDatum could foreseeably be overridden



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)