Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@streams.incubator.apache.org
From: robdouglas <git@git.apache.org>
To: dev@streams.incubator.apache.org
Reply-To: dev@streams.incubator.apache.org
References: <git-pr-113-incubator-streams@git.apache.org>
In-Reply-To: <git-pr-113-incubator-streams@git.apache.org>
Subject: [GitHub] incubator-streams pull request: resolves Streams 187
Content-Type: text/plain
Message-Id: <20141028170937.912BC99646B@tyr.zones.apache.org>
Date: Tue, 28 Oct 2014 17:09:37 +0000 (UTC)

Github user robdouglas commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/113#discussion_r19486372
  
    --- Diff: streams-contrib/streams-amazon-aws/streams-persist-s3/src/main/java/org/apache/streams/s3/S3PersistWriter.java ---
    @@ -256,13 +258,15 @@ public void prepare(Object configurationObject) {
                     AWSCredentials credentials = new BasicAWSCredentials(s3WriterConfiguration.getKey(), s3WriterConfiguration.getSecretKey());
     
                     ClientConfiguration clientConfig = new ClientConfiguration();
    -                clientConfig.setProtocol(Protocol.valueOf(s3WriterConfiguration.getProtocol().toUpperCase()));
    +                clientConfig.setProtocol(Protocol.valueOf(s3WriterConfiguration.getProtocol().toString()));
     
    -                // We want path style access
    +                // We do not want path style access
                     S3ClientOptions clientOptions = new S3ClientOptions();
    --- End diff --
    
    What was the motivation behind this change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---