Mailing-List: contact dev-help@streams.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@streams.incubator.apache.org
From: robdouglas <git@git.apache.org>
To: dev@streams.incubator.apache.org
Reply-To: dev@streams.incubator.apache.org
References: <git-pr-107-incubator-streams@git.apache.org>
In-Reply-To: <git-pr-107-incubator-streams@git.apache.org>
Subject: [GitHub] incubator-streams pull request: STREAMS-197 | New
 counting/tacking...
Content-Type: text/plain
Message-Id: <20141021191150.9E26393B430@tyr.zones.apache.org>
Date: Tue, 21 Oct 2014 19:11:50 +0000 (UTC)

Github user robdouglas commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/107#discussion_r19171702
  
    --- Diff: streams-runtimes/streams-runtime-local/src/test/java/org/apache/streams/local/counters/DatumStatusCounterTest.java ---
    @@ -0,0 +1,134 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.streams.local.counters;
    +
    +import com.carrotsearch.randomizedtesting.RandomizedTest;
    +import com.carrotsearch.randomizedtesting.annotations.Repeat;
    +import org.junit.After;
    +import org.junit.Test;
    +
    +import javax.management.InstanceNotFoundException;
    +import javax.management.ObjectName;
    +import java.lang.management.ManagementFactory;
    +
    +/**
    + *
    + */
    +public class DatumStatusCounterTest extends RandomizedTest {
    +
    +    private static final String MBEAN_ID = "test_id";
    +
    +
    +
    +    /**
    +     * Remove registered mbeans from previous tests
    +     * @throws Exception
    +     */
    +    @After
    +    public void unregisterMXBean() throws Exception {
    +        try {
    +            ManagementFactory.getPlatformMBeanServer().unregisterMBean(new ObjectName(String.format(DatumStatusCounter.NAME_TEMPLATE, MBEAN_ID)));
    +        } catch (InstanceNotFoundException ife) {
    +            //No-op
    --- End diff --
    
    Is there a reason you're not logging the exception here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---