streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-199) Implement new Changes to StreamTasks
Date Sun, 26 Oct 2014 01:04:34 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184341#comment-14184341
] 

ASF GitHub Bot commented on STREAMS-199:
----------------------------------------

Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/109#discussion_r19378453
  
    --- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsPersistWriterTask.java
---
    @@ -111,14 +113,18 @@ public void run() {
                         Thread.currentThread().interrupt();
                     }
                     if(datum != null) {
    +                    this.counter.incrementReceivedCount();
                         try {
    +                        long startTime = System.currentTimeMillis();
                             this.writer.write(datum);
    +                        this.counter.addTime(System.currentTimeMillis() - startTime);
                             statusCounter.incrementStatus(DatumStatus.SUCCESS);
                         } catch (Exception e) {
                             LOGGER.error("Error writing to persist writer {}", this.writer.getClass().getSimpleName(),
e);
                             this.keepRunning.set(false); // why do we shutdown on a failed
write ?
    --- End diff --
    
    Can we remove this line?  I'd prefer a single write failure not terminate the component.


> Implement new Changes to StreamTasks
> ------------------------------------
>
>                 Key: STREAMS-199
>                 URL: https://issues.apache.org/jira/browse/STREAMS-199
>             Project: Streams
>          Issue Type: Sub-task
>            Reporter: Ryan Ebanks
>
> Implement new Changes to StreamTasks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message