streams-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (STREAMS-199) Implement new Changes to StreamTasks
Date Sat, 25 Oct 2014 19:04:34 GMT

    [ https://issues.apache.org/jira/browse/STREAMS-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184222#comment-14184222
] 

ASF GitHub Bot commented on STREAMS-199:
----------------------------------------

Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/109#discussion_r19377072
  
    --- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/tasks/StreamsProcessorTask.java
---
    @@ -21,13 +21,11 @@
     import com.google.common.collect.Maps;
     import org.apache.streams.core.*;
     import org.apache.streams.core.util.DatumUtils;
    +import org.apache.streams.local.counters.StreamsTaskCounter;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
    -import java.util.LinkedList;
    -import java.util.List;
    -import java.util.Map;
    -import java.util.Queue;
    +import java.util.*;
    --- End diff --
    
    not a fan of importing *.  you can't tell intellij to never do this but you can tell it
to require a ridiculously high threshold like 10000


> Implement new Changes to StreamTasks
> ------------------------------------
>
>                 Key: STREAMS-199
>                 URL: https://issues.apache.org/jira/browse/STREAMS-199
>             Project: Streams
>          Issue Type: Sub-task
>            Reporter: Ryan Ebanks
>
> Implement new Changes to StreamTasks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message